Remove AutoMergeProcessWorker parameter backwards compatibility
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
The Problem
In Gitlab %17.5, we changed the AutoMergeProcessWorker to accept a hash instead of a single merge request id: Set up the AutoMergeProcessWorker to accept a h... (!168123 - merged)
We did this to enable Move completed pipeline merge request querying ... (!167095 - merged)
and ultimately Improve PipelineProcessWorker performance by us... (#483008 - closed)
To maintain backwards compatibility, we added this type check at the top of the method:
class AutoMergeProcessWorker # rubocop:disable Scalability/IdempotentWorker
...
def perform(options)
# TODO remove this backwards compatibility in GitLab 18.0
options = { merge_request_id: options } unless options.is_a?(Hash)
This, while small and self-contained, is not something we want to keep long-term, as we don't want to support passing integers indefinitely.
A Proposal
- Remove the raw id support, by (functionally) reverting d93772d9
Edited by 🤖 GitLab Bot 🤖