Align permission checks for `stop_environment`
Proposal
Simplify permissions in app/policies/environment_policy.rb
to only allow stop_environment
if user can update_environment
. Execution of stop actions will occur with the original user so we don't need to check if the user is allowed to update these jobs.
We should also clarify this behavior in the documentation:
- clarify that user triggering the stop environment will only stop the environment.
- Side effects such as running stop actions will run with the original job's user.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Tiger Watson set weight to 2
set weight to 2
- 🤖 GitLab Bot 🤖 added typemaintenance label
added typemaintenance label
- 🤖 GitLab Bot 🤖 added devopsdeploy sectioncd labels
added devopsdeploy sectioncd labels
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#19992 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19992 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20125 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20125 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20243 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20243 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20325 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20325 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20441 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20441 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20578 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20578 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20746 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20746 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20826 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20826 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20945 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20945 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#21135 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21135 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#21255 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21255 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#21332 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21332 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#21441 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21441 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#21516 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21516 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#21701 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21701 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#21816 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21816 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#21892 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21892 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#22000 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22000 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#22188 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22188 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#22300 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22300 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#22378 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22378 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#22484
mentioned in issue gitlab-org/quality/triage-reports#22484