Users with developer and higher permissions show up as eligible approvers of "reporter" groups specifically configured for MR approval but "Approve" button is missing.

Summary

Users with developer and higher permissions show up as eligible approvers of "reporter" groups specifically configured for MR approval but "Approve" button is missing.

Steps to reproduce

1. Setup users and groups as the steps in this doc. e.g. Subgroup A will have users with reporter access that will be added to a project for the purpose of MR approval.
2. Instead of the reporter role in Subgroup A, make users have developer. Subgroup A's permissions to the project will still remain reporter. Just the user membership to Subgroup A will be changed.
3. Users with the developer permissions to Subgroup A will show up as eligible approvers but they won't have an "Approve" button.

Example Project

https://gitlab.com/ndesilva-gold/sub2/test2

What is the current bug behavior?

Users with developer and higher permissions show up as eligible approvers of "reporter" groups specifically configured for MR approval but "Approve" button is missing.

What is the expected correct behavior?

Users with developer and higher permissions shouldn't show up as eligible approvers of "reporter" groups specifically configured for MR approval or "Approve" button should show for users that show up as eligible approvers.

Relevant logs and/or screenshots

Output of checks

This bug happens on GitLab.com

Possible fixes