Skip to content

[Feature tests]: Merge request approval policy backend validation

Why are we doing this work

We need to cover edge cases for security polices.

Policy type: Merge request approval policy

By default submit button Configure with a merge request is enabled:

Test scenario Completed
Edit existing result policy for a group !170179 (merged)
Edit existing result policy for a project !170179 (merged)
  1. Validation happens on backend
  2. This case should validate all required properties
  3. If required property is omitted, user sees validation error message and creating merge request flow will not proceed

List of required properties:

  • Policy name
  • Actions: required approvals
  • Rules: at least one rule is required, better to test against every type
  • Rules: licence rule: license_types, license_states

Relevant links

  1. Feature specs guide
  2. Testing best practises

Non-functional requirements

Add details for required items and delete others.

  • Documentation:
  • Feature flag:
  • Performance:
  • Testing:

Implementation plan

  1. Create test in ee/spec/features/groups/security
  2. Or add subfolder security_orchestration
Edited by Artur Fedorov