Skip to content

Number of changes in MR changes when scrolling through specific commit

Summary

When:

  1. Looking at a specific commit in an MR which has a different amount of changes than the MR itself, and
  2. Scrolling down and having the tabs follow

The number of changes jumps between the number of changes in the MR to the number of changes in the commit when switching between the "scrolling mode" of the tab bar and the regular display.

Steps to reproduce

  1. Look at an MR with some changes (e.g. !164348 (diffs)).
  2. Choose a specific commit from the commits page and look at the diff (e.g. !164348 (095a7402))
  3. Scroll down and look at the number of changes

Example Project

What is the current bug behavior?

The number of changes jumps between the number of changes in the MR to the number of changes in the commit when switching between the "scrolling mode" of the tab bar and the regular display.

What is the expected correct behavior?

The number of changes should stay the same and reflect the number of changes in the current context (i.e. the commit I'm looking at) regardless of my position on the page.

Relevant logs and/or screenshots

A video!

MRBug

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes