Skip to content

[Design] Reviewer assignment drawer post-feedback

Proposal

We can link the drawer from the "Assign" button in the sidebar as well as other areas of the merge request like in the "All required approvals must be given" merge check.

CleanShot_2024-09-12_at_13.19.20

📺 Walkthrough

🕹️ Prototype

Isn't this just quick assign

Quick assign was the concept of putting a + next to Edit. I personally never liked it because it didn't relate to why I would want to do quick add versus the drawer? Why would someone choose slow over quick?

The small change is linking the assignment drawer to required approvals.

You have required approvals that you need to assign reviewers to

  • Requires X approvals: Opens to show required rules
  • Approvals optional: You don't need to assign reviewers but the rules exist. There might be workflows where teams use optional approval rules because there isn't enough logic to trigger them into required ones.
  • Approvals are not setup: User may be using a free instance or have not setup approval rules or CODEOWNERS so in this case scenario, the experience is the same as the current.

In fact the "Edit" experience of the dropdown is all the same for the different cases of approvals being required/optional/disabled.

CleanShot_2024-09-12_at_13.06.52

Foundation

The reviewer assignment drawer can be the foundation of automation features that make it easier to assign reviewers

Suggested reviewers
  1. Concept 1: Suggested reviewers in dropdown
  2. Concept 2: Suggested reviewers prefilled
    • User needs to "assign" to lock in selection
  3. Concept 3: Auto assign button
    • Assigns required approval rules

image

Automated code review

Assigns "Duo Code Reviewer" as an additional reviewer

image

Past concepts

  • Separating the selection of reviewers and those that satisfy rules. Video walkthrough
    • Not going with this because Approving is an action and Reviewer is the role
  • Inline assignment in the sidebar
Edited by 🤖 GitLab Bot 🤖