Introduce button to "Add to review" to Overview tab

Proposal

Currently you can only start a review by commenting on code from the Changes tab. However if you are reviewing on the functionality the place to leave that type of comment is in the "Overview" tab.

Goals of the change:

  • Eliminate thread/comment distinction on Overview tab for things part of a review
  • Effectively all comments left in a review are threads
  • Match the labelling of buttons from Changes tab
  • Keeps the existing "commenting" behavior as is until the user enters a review and then we swap the review to be the primary action
    • This allows us to have our opinionated view on being able to start a review from the Overview tab, making that the default behavior during a review, while not conflicting with those who are accustomed to just commenting and using cmd+enter #474805 (comment 2026380197) #387369 (closed) #388913

Default view

  • Start a review displayed on Overview tab
    • Secondary action to the existing comment button
Current - Overview (default with text) Proposal - Overview (default with text)
image image

Once a review has been started

  • Add to review button is primary action
    • Threads are added to review when clicked
    • Behavior is similar to how the Changes tabs works
  • Add comment now - secondary action
Current - Review started Proposal - Review started
image image

For the scenario of the internal note, labels for the review related buttons shouldn't need to change

Current - Review started (internal) Proposal - Review started
image image
Original proposal prior to 8 Nov 2024

Currently you can only start a review by commenting on code from the Changes tab. However if you are reviewing on the functionality the place to leave that type of comment is in the "Overview" tab.

  • Make the default behaviour "Add to review"
  • Remove the split dropdown for "Comment"/"Thread"
Current Proposal
CleanShot_2024-08-15_at_16.22.49 CleanShot_2024-08-15_at_16.26.06

There could be concerns that this change is moving the default behaviour away from leaving a comment. This is something we acknowledge and feel that even with certain actions today such as leaving comments in code as a way to guide code reviews #474805 (comment 2020789403) or doing self reviews would benefit to be contained as a "review".

This scope does not include replies to existing comments. This requires further refinement #474794 (comment 2026608912)

Edited by Michael Le