Support self-managed instances for agent connect command
In Provide connect command for agent cluster (#463769 - closed) we've introduced in a new modal that shows a glab
command to connect to an agent. However, that command doesn't account for self-managed GitLab instances.
To support those the GITLAB_HOST
environment variable must be set properly for glab
to connect to the proper host.
Implementation guide
- Update
connect_to_agent_modal
- Add the
GITLAB_HOST=${currentHost}
part at the beginning of the command in case it's notgitlab.com
- Update the corresponding tests.
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Timo Furrer added featureaddition groupenvironments workflowscheduling labels
added featureaddition groupenvironments workflowscheduling labels
- Timo Furrer set weight to 1
set weight to 1
- Timo Furrer marked this issue as related to #463769 (closed)
marked this issue as related to #463769 (closed)
- 🤖 GitLab Bot 🤖 added typefeature label
added typefeature label
- 🤖 GitLab Bot 🤖 added devopsdeploy sectioncd labels
added devopsdeploy sectioncd labels
- Author Maintainer
Collapse replies - Maintainer
Thanks for opening an issue, @timofurrer! Does this updated command look correct (it will only add the host part if it's not
gitlab.com
)? - Author Maintainer
@anna_vovchenko Yes, exactly
1 - Contributor
is it okay/possible to compute the
currentHost
value fromwindow.location.host
? - Contributor
from !171865 (comment 2199474742)
It might be worth considering using gon.gitlab_url here, as it represents the canonical URL set by the server. This approach could also simplify testing.
- Maintainer
Thanks for working on this, @MatteoAxelle! I’ll go ahead and assign the issue to you since you're actively working on it.
1
- Timo Furrer changed milestone to %Backlog
changed milestone to %Backlog
- Anna Vovchenko added frontend label
added frontend label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#19283 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19283 (closed)
- Anna Vovchenko changed the description
Compare with previous version changed the description
- Anna Vovchenko added Seeking community contributions quick win labels
added Seeking community contributions quick win labels
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#19367 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19367 (closed)
- Deepak kumar mentioned in merge request !163969 (closed)
mentioned in merge request !163969 (closed)
- Veethika Mishra assigned to @Deepak18-06
assigned to @Deepak18-06
- 🤖 GitLab Bot 🤖 removed Seeking community contributions label
removed Seeking community contributions label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#19538 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19538 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#19653 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19653 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#19665 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19665 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#19802 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19802 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#19912 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19912 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#19992 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19992 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20125 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20125 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20243 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20243 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20325 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20325 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20441 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20441 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20578 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20578 (closed)
- Mattéo Axelle mentioned in merge request !171865 (merged)
mentioned in merge request !171865 (merged)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20746 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20746 (closed)
- Anna Vovchenko added Community contribution label
added Community contribution label
- Anna Vovchenko assigned to @MatteoAxelle and unassigned @Deepak18-06
assigned to @MatteoAxelle and unassigned @Deepak18-06
- Anna Vovchenko added workflowin review label and removed workflowscheduling label
added workflowin review label and removed workflowscheduling label
- Anna Vovchenko changed milestone to %17.6
changed milestone to %17.6
mentioned in issue gitlab-org/ci-cd/deploy-stage/environments-group/general#97 (closed)
- Anna Vovchenko changed milestone to %17.7
changed milestone to %17.7
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#20826 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20826 (closed)
- Maintainer
Closing the issue as the related MR is done and deployed to production.
Thanks for your contribution, @MatteoAxelle!
- Anna Vovchenko added workflowcomplete label and removed workflowin review label
added workflowcomplete label and removed workflowin review label
- Anna Vovchenko closed
closed