Skip to content

Merge request approval policies to override project-level settings not reflected in project settings

Summary

Applying a merge request approval policies to enforce project-level settings is not reflected in the Settings > Merge requests > Merge request approvals section.

Steps to reproduce

  • Create a merge request approval policy for a project and override project-level settings
  • Browse to project-level settings at Settings > Merge requests > Merge request approvals
  • There is no indication that the settings are configured/overridden by the merge request approval policy

Example Project

What is the current bug behavior?

When merge request approval policies are used to enforce project-level settings this is not reflected in the Settings > Merge requests > Merge request approvals section.

image.png

What is the expected correct behavior

When merge request approval policies are used to enforce project-level settings this should be reflected in the Settings > Merge requests > Merge request approvals section.

Possibly indicate in the settings that the settings may be affected by merge request approval policies being applied.

Proposal

Merge request settings Warning in affected merge requests
image.png image.png

Relevant logs and/or screenshots

N/A

Output of checks

This bug happens on GitLab.com

Requesting Customers

  1. https://gitlab.my.salesforce.com/0016100000W2eBoAAJ (internal only) - see comment
  2. https://gitlab.zendesk.com/agent/tickets/554913
Edited by Grant Hickman