Skip to content

Update Run/Create Pipeline Alert Error Message

Problem to solve

The following discussion from !157212 (merged) should be addressed:

image

I don't think we can use Markdown here. I tried changing it to HTML instead, but it looks like any HTML is also stripped from these messages on their way to the frontend. Couldn't quite figure out how to work around that or I'd just have proposed a fix MR.

I'm also wondering about the lowercase sentence beginning – are these suppose to be shown in a list normally? It looks off in this context to not start with uppercase The. 🤔

Thanks for catching this @manuelgrabowski!! - I think I understand what is happening here - There seems to be some inconsistency in how Ci:PipelinePresenter.failure_reasons is used. Sometimes for system notes and in this example for an alert - and those 2 use cases are different - I will create an issue to correct this.

I am wondering if we actually have 2 different class methods

  1. failure_reason
  2. system_note_failure_reason

or something that distinguishes the 2

As a result of updating the content of system notes to use different documentation links based on failure reason - a side effect has been discovered that the same failure reason messages are used in the alert displayed when a createPipeline mutation returns an error related to a pipeline failing due to a rules or workflow rules

Proposal