Do not reload MR approvals on any Branch rule edits
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Summary
Saving branch protection on the Branch rule details page causes MR approval rules section to reload
Steps to reproduce
- Go to Project / Settings / Repository / Branch rules and click View details for a rule
- In Allowed to merge or Allowed to push and merge section click Edit
- Change any settings in the drawer and click Save changes
Example Project
Any project within EE instance, that has edit_branch_rules feature flag enabled.
What is the current bug behavior?
Saving edited branch protection causes MR approval rules to reload, when the branch protection mutation is submitted.
What is the expected correct behavior?
Branch protection section reloads with new data, while MR approval rules section stays untouched.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)(we will only investigate if the tests are passing)