Skip false positive dependency scanning advisories
Proposal
Our dependency scanning feature relies on the GitLab Advisory Database to
match dependencies with known advisories. At times, we have yanked (changed
decision on) advisories from the database because they have been disputed,
and proven to be false positives. These advisories
are titled as False postive in the database, so we have a heuristic where
we can skip over the vulnerability creation if:
- They're sourced from GLAD
- They're titled
False positive
This would prevent unnecessary vulnerability openings, and reduce the noise in the security reports of our customers.
Implementation
- Update Gemnasium's advisory matching to skip vulnerabilities that have a
False PositiveName.- Create tests that verify the advisory is skipped during vulnerability creation.
- Update the
pm_advisoriesingestion to skip ingestion and scanning of advisories that have aFalse Positivetitle and and havegladas thesource_xid.- Add test that verifies the advisory ingestion is skipped.
- Update PMDB to skip ingestion of advisories that have a
False Positivetitle and are sourced fromglad- Add unit test that verifies the advisory ingestion is skipped.
Edited by Oscar Tovar