Skip to content

"Find file" search percent sign % special character

Summary

"Find file" search does not handle % in file name correctly. Observed with Firefox 127.0 (64-bit) on Linux.

Steps to reproduce

  1. Have a file with % in its file name.
  2. Click on "Find file" in the repo and search for the file, either by other part of its filename or by typing %
  3. Click on the found file, get "400 Bad Request"

Example Project

https://gitlab.com/soft.at.home/buildsystems/yocto/meta-amx

What is the current bug behavior?

Link contains % like a regular character, thus leading to 400 Bad Request

What is the expected correct behavior?

Clicking the link leads to the file.

The percent sign should be url-encoded.

Relevant logs and/or screenshots

n/a

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes