Skip to content

MR widget doesn't show codeowner approvers

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

When there are multiple groups and the user who's viewing the MR isn't in ALL of the approver groups listed. The widget doesn't show any approver icon.

Steps to reproduce

Have the following setup:

Top Level group: UserA

  • ApproverGroup1: User1 User2 User3
  • ApproverGroup2: User1 User4 User5
  • Project: User6 ApproverGroup1 ApproverGroup2
    • CODEOWNERS 
      [TestApprover][1]
testfile.txt @toplevelgroup/ApproverGroup1 @toplevelgroup/ApproverGroup2
    • testfile.txt
  1. As User6 create an MR that change the testfile.txt
  2. Observe that the MR requires one approval but the icon of the approvers doesn't appear in the approval widget. This also applies to User2 User3 User4 and User5.
  3. As User1 or UserA view the MR and see that all the approvers appear in the Approval widget

NOTE: Any of the user can see the approver users in the approver list if they click the EDIT button to edit the MR and expand the approver list.

This could relates to Group visibility prevents viewing Code Owners i... (#404952 - closed)

Example Project

What is the current bug behavior?

Approvers don't appear in the Approval widget.

What is the expected correct behavior?

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes

Edited by 🤖 GitLab Bot 🤖