Wiki: refactor to reduce nested #capture_git_error calls
Related to: !156411 (comment 1956434870)
As far as I could see in the code base, I still think that we can make the
#capture_git_error
private, as it being used outside of theWikiPage
seems like a leak of internals IMHO. This should be quite straightforward because:
- Currently,
WikiPages::CreateService
callspage.create
from within acapture_git_error
, but thepage.create
already uses thecapture_git_error
internally, so I don't see a reason why we're using it twice.- Same thing happens on
WikiPages::UpdateService
, it's callingpage.update
from within acapture_git_error
, but thepage.update
already calls thecapture_git_error
internally, therefore I think we can remove the external call as well.