Self-hosted default value for gitlab documentation link causes 500
When the settings value for /admin/application_settings/preferences#js-help-settings > Documentation pages URL
is left unset, which should use the implied default https://docs.gitlab.com
as before, any access to the linked URL <domain>/help/docs
will cause an internal 500:
ActionController::ActionControllerError HelpController#redirect_to_docs
Cannot redirect to nil!
Explicitly setting the value fixes the issue.
This seems to have been caused by the fix for #415316 (closed) in !149559 (merged).
Running latest 17.0.2 self-hosted free.
Mentioning you @thutterer @apennells @leipert as reviewers of the MR so you probably have this fresh on your minds
/cc @fh1ch
Edited by Diego Louzán