Verify all instances of `stage` with `ci_stage` in specs and update if necessary
With the upcoming removal of the stage
column, we should update the specs that use stage: string
for setting a stage to a CommitStatus
(or any of its children) to ci_stage: stage
Example:
# old
create(:ci_build, stage: 'test')
# new
stage = create(:ci_stage ....)
create(:ci_build, ci_stage: stage)
This will allow us to get rid of the chunky after(:build)
and before(:create)
in the CommitStatus
and Ci::Processable
factories, which are currently being used to handle the specs with the old setup stage: string
.
NOTE: The factories are handling the creation of a ci_stage
, so it might just be that the stage can be removed altogether and the spec can pass
As of June 2024 there are these many matches (number can be inaccurate as it was a quick ag
):
868 matches
181 files contained matches
Epic: &11809