Checkbox for "Viewed" does not allow for additional keyboard shortcut because it is still in focus
Summary
For the merge request diff files "Viewed" checkbox, the focus state stays even after the user selects/unselects the option.
From #327153 (comment 1636712107)
Not only that the checkbox does not have a hotkey, but also clicking the box will prevent the other hotkeys from working.
Steps to reproduce
- Go to a merge request with multiple files changed, go to the "Changes" tab
- Go to the second file and click "Viewed"
- Try to navigate to the previous or next via a keyboard shortcut
What is the current bug behavior?
Focus state stays open and the currently active file diff doesn't change.
What is the expected correct behavior?
Upon selecting/unselecting the Viewed checkbox, the focus on the checkbox should be removed so that keyboard shortcuts can resume.
Relevant logs and/or screenshots
Current workaround
User needs to know to tab out of the checkbox then keyboard shortcuts are active again.
Possible fixes
When focused on a checkbox, the keyboard shortcuts should still work, just like how it works currently when the focus is on a button element.
Edited by Michael Le