Role Change on Ultimate Can Result in Going Over User Cap
Problem
- Say I'm at my user cap (which could be the max seats in my license if we set it to that). I can block a user and my seat count goes down by one. Then a new user can sign up and I'm back at max seats. Now say I unblock the blocked user. Now I'm over my seat count. I tried this and it works as I describe here; nothing prevents me from unblocking the user and exceeding my user cap. (handled by this issue #463652)
- Similarly, on an Ultimate license, I can do the same dance, but just adjusting memberships. Say a user is billable because it has one membership in a group at the Developer level. I can do the same dance, but just adjusting this member to Guest and back to Developer rather than blocking and unblocking.
I imagine this impacts SM & GitLab.com Ultimate customers.
Solution
When you adjusting this member to Guest and back to Developer
and you are at your user cap, that user would instead become a pending user for approval.
Note while this work &12141 will help with this problem, it will only do so if someone has user caps & manage guest promotions enabled.
Edited by Alex Martin