Skip to content

Unify spacing in project and group item components

group_item.vue and project_item.vue components have a tiny difference in spacing - the avatar in group item is placed with the name inside one container and does not receives flex gap. The difference doesn't seem big, but since both components appear next to each other, it can be easily spotted:

Screenshot_2024-05-24_at_15.31.18

To do:

  • place the avatar in group_item.vue outside the wrapping div, so that flex gap is present between the avatar and the group name
  • change div element to span for a correct HTML structure. Block elements should not be nested inside inline elements.

File to edit:

How to reproduce:

  1. Open Rails console. In your terminal: rails c
  2. Enable the feature flag:
Feature.enable(:edit_branch_rules)
  1. In a project, go to Settings / Repository
  2. Expand Branch rules section
  3. Create a rule or choose already existing one. Click View details
  4. Click Edit in the Allowed to merge section. A drawer containing components in question will open.
Edited by Paulina Sedlak-Jakubowska