Automated Testing -- 1️⃣ [Iteration 1 - Self-Managed] Add Controls for Ability to Promote Guest Users

Initial investigation

While taking a look at this I understood we have these views/user flows:

  1. Enabling the feature via Admin > Settings > General > Sign-up restrictions (docs)
  2. Group Owner adding a member and having them pending promotions (docs)
  3. Admin checking what are the pending promotions for their instance (docs)

We have other use cases (e.g. admin adding user bypassing the pending promotion) but I think we have those covered in other test layers (unit / integration), and here in e2e tests we should cover only the main cases. We can also change that in the future.

Implementation

I received feedback about the previous implementation (below) in !171085 (comment 2188133758)

The new path forward was to add this tests at integration layer (feature tests). Here are the MRs for that:

Previous implementation

I created Add e2e tests for role promotion management (!171085 - closed) and am awaiting for further guidance from SETs.

The main file to look at in the MR diff is member_management_spec.rb. In there we cover case 1 in the test setup, case 2 in the first it block, and case 3 in the second it block.

I also created 2 Test cases:

  1. Test Case to assert it shows members pending promotion on group members page
  2. Test Case to assert it shows members pending promotion on admin users page
Original issue description

Question to consider

  1. What end to end automated tests should we have / stand up related to the SM feature of controls to manage guest promotions?

Ask

  • Once we have an answer to above question, create necessary issues to establish those automated tests

Resources

Edited by Sheldon Led