Runners page shows "Upgrade recommended" even after runner (Kubernetes executor) is upgraded to the latest version of helm chart
Summary
Runners page displays the "Upgrade recommended" label even though runner is updated to the latest version.
Steps to reproduce
- On GitLab UI, get a runner token by creating a new runner in your group.
- Install an older version of runner via Runner helm chart
helm upgrade -i runner-upgrade gitlab/gitlab-runner --version 0.61.3 -f values-version-test.yml -n upgrade-test --create-namespace
- Keep upgrading until the latest version:
helm upgrade -i runner-upgrade gitlab/gitlab-runner --version 0.62.0 -f values-version-test.yml -n upgrade-test --create-namespace
helm upgrade -i runner-upgrade gitlab/gitlab-runner --version 0.62.1 -f values-version-test.yml -n upgrade-test --create-namespace
helm upgrade -i runner-upgrade gitlab/gitlab-runner --version 0.64.1 -f values-version-test.yml -n upgrade-test --create-namespace
...
emunn@elif-dev nlb % helm history runner-upgrade -n upgrade-test
REVISION UPDATED STATUS CHART APP VERSION DESCRIPTION
1 Tue May 14 17:25:57 2024 superseded gitlab-runner-0.61.3 16.8.1 Install complete
2 Tue May 14 17:28:20 2024 superseded gitlab-runner-0.62.0 16.9.0 Upgrade complete
3 Tue May 14 17:29:46 2024 superseded gitlab-runner-0.62.1 16.9.1 Upgrade complete
4 Tue May 14 17:30:29 2024 superseded gitlab-runner-0.63.0 16.10.0 Upgrade complete
5 Tue May 14 17:31:34 2024 superseded gitlab-runner-0.64.0 16.11.0 Upgrade complete
6 Tue May 14 17:32:14 2024 deployed gitlab-runner-0.64.1 16.11.1 Upgrade complete
emunn@elif-dev nlb %
- On the UI, go to group and navigate to Build > Runners
- Click the runner id to open details, then click "Show details" to expand
- All the previous deployments keep showing online
- On top of the page, "Upgrade recommended" label is displayed.
Example Project
https://gitlab.com/e_munn_ultimate_group/tests
What is the current bug behavior?
- Runners page is displaying previous deployments as online
- "Upgrade recommended" label is displayed even when runner is upgraded to the latest version.
What is the expected correct behavior?
-
Upgrade recommended
label should not show after upgrading the runner to the latest available version. - Previous deployments should not show as online.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
Upgrade recommended
label won't show when:
- Uninstall the runner
- Install the latest version