Wrong agentk version recommendation on GitLab.com
The current Rails code is somewhat inaccurate in deducing the version for agentk and falls back to the GitLab version in case the version in the GITLAB_KAS_VERSION file is a SHA.
This works okay for GitLab self-managed but is a problem for GitLab.com where the GitLab version will almost always point to MAJOR.MINOR + 1.
I think we really do need Use ServerInfo gRPC endpoint to retrieve KAS ve... (#458891) asap (we decided not to do this, see proposal below)
For GitLab.com we can simplify the fix and just NOT reference a version at all so that the latest is used. This is anyways the correct behavior for GitLab.com.
This bug only affects GitLab.com and not self-managed, because we have stable tags there.
Old implementation plan
Implementation Plan
- Start to version the GitLab Agent Helm Chart with the same version as GitLab and GitLab Agent. We anyways almost always release at the same time. We'll need this anyways with Extend gitlab-agent release process to GitLab A... (gitlab-com/gl-infra/delivery#20169).
- As long as we don't have gitlab-com/gl-infra/delivery#20169 we need to manually create the patch releases from stable branches. So now that we have Run gitlab-agent pipeline on releases to deploy... (gitlab-com/gl-infra/delivery#20168 - closed) we can also start refining the aforementioned issue.
- On GitLab self-managed: install the same version as GitLab (this will always work, since we have a GitLab Agent Helm Chart release for every GitLab release)
- On GitLab.com: don't specify the version at all - we always want the latest.
Edited by Timo Furrer