Backend: Enable `:yaml_processor_feature_flag_correctness` flag by default on RSpec tests
Summary
As a result of a recent incident in gitlab-com/gl-infra/production#17819 (closed), we moved YamlProcessor::FeatureFlags
to Ci::Config
(safe place for YAML to be processed via Ci::YamlProcessor
) to prevent any incidents and so Sentry won't be overwhelmed in the future.
As a follow-up from the discussion in gitlab-org/quality/quality-engineering/team-tasks#2693 (comment 1899381279), we have a flag :yaml_processor_feature_flag_correctness
which can be enabled on the RSpec tests so that YamlProcessor::FeatureFlags
are working correctly, and it has enabled it on several spec files.
Proposal
Enable :yaml_processor_feature_flag_correctness
by default for all specs on RSpec tests.
Confirm purpose and User Reception (how does this benefit the user?)
Related to GitLab availability and no future incidents.
Additional details
Some relevant technical details, if applicable, such as:
- Does this need a feature flag?
- Does there need to be an associated instrumentation issue created related to this work?
- Is there an example response showing the data structure that should be returned (new endpoints only)?
- What permissions should be used?
- Is this EE or CE?
-
EE -
CE
-
- Additional comments: