When submitting an MR review, the Summary dialog remains open
Summary
Summary comment dialog box remains after submitting a review. The review gets submitted successfully but it remains open and the comments look like they are still pending. After refreshing the page everything there are no pending comments and you can see the review was submitted successfully
This screenshot was after pressing Submit review
:
It occurred on cli!1462 (merged)
I cannot seem to reproduce but I have seen this happen a few times. In each case I am pretty sure I only added code comments and a summary comment, and I submitted from the Changes tab
Steps to reproduce
- create a new MR which adds a file
- Select Changes tab
- add one pending comment on the diff (add to review)
- from the changes tab click
Finish review
- Enter summary comment (important)
- Select
Comment
(should already be selected) - Press
Submit review
What is the current bug behavior?
Summary comment dialog remains open
Pending comments remain (see screen shot 5
)
What is the expected correct behavior?
Summary comment dialog closes, no pending comments
Workaround
Refresh page
Edited by Jay McCure