Follow-up from "Remove license compliance app"
The following discussion from !150831 (merged) should be addressed:
-
@fernando-c started a discussion: (+3 comments) @dpisek please read the proposal section first.
Overall this looks good, but there is still some dead code lingering in
We still need some of these vue components for the Pipeline-> License tabs, but there is functionality no longer needed that is embedded in the actions, mutations, store, and vue components themselves.
Also the Vue app removal for the license list.
- Adding/Deleting Licenses (can remove actions, mutations, and vue components related to it)
- We can also remove https://gitlab.com/gitlab-org/gitlab/-/blob/439181-license-compliance-license-list-ui-removal/ee/app/assets/javascripts/vue_shared/license_compliance/license_management.vue it was the main app for the license list page, the one you were removing in this MR
- The pipeline license tab is instead boot strapped by https://gitlab.com/gitlab-org/gitlab/-/blob/439181-license-compliance-license-list-ui-removal/ee/app/assets/javascripts/vue_shared/license_compliance/mr_widget_license_report.vue We still need that component and it's dependenicies.
Feel free to address these changes in a follow-up issue and MR, let me know if you want to proceed that way and I can create the issue and capture the remaining work. It would be code cleanup/tech debt.
For now, I don't think we should block your MR since it does accomplish removing the license list in terms of the UX experience.