If I change the title of a draft MR, GitLab sends a "marked as draft" notification even though the draft-status did not change
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Summary
Gitlab helpfully emails out notifications when an MR is set to a status of Draft. GitLab tracks the draft-status of an MR prefixing the title of the MR with "Draft:".
However, if I edit the title of an MR already in a status of draft GitLab will send out an email notification as-if the MR were newly marked as draft.
That is, if I change the title of an MR from Draft: foo to Draft: bar GitLab will send a notification informing interested parties that I have marked the MR as Draft.
This is wrong in two ways:
- The draft-status of the MR did not change, so the email does not need to be sent
- I was probably not the person who actually changed the MR to draft
Steps to reproduce
Create an MR such that multiple people receive notifications (you will not be notified for your own actions).
- Change the title of the MR to "Draft: something".
- Change the title of the MR to "Draft: something else".
The second rename should not send an email, but it does.
Example Project
What is the current bug behavior?
Both MR-title changes trigger a "changed to draft" email notifications.
What is the expected correct behavior?
The second name-change should not have sent a "changed to draft" email notification.
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Gitlab version: v16.10.1-ee
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)(we will only investigate if the tests are passing)