Improve the support of NTFS in backup process

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Summary

Currently we try to set mode option when making directories, NTFS on Linux doesn't support this, and will break the backup process if backups is located on a NTFS volume.

Steps to reproduce

1. links the backups directory to a NTFS volume
2. Run gitlab-backup create Currently I'm using 13.x, but the latest code seems still use this flag: https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/import_export/command_line_util.rb

Example Project

What is the current bug behavior?

What is the expected correct behavior?

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)
(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)
(we will only investigate if the tests are passing)

Possible fixes

Maybe we can introduce an optional flag to disable this behavior, or detect the filesystem (not very elegant though) and set the mode conditionally