'Add approval rule' UI polish opportunities

While reviewing !150491 (merged) I identified a few opportunities for consideration

• Approvers list size
• 'Add approvers' scope the search first
• Form submission at end of form
• Drawer keyboard trap
• Target branch dropdown migration

Approvers list size

As this is in a drawer, could the approvers list grow to fill the remaining space?

Before	After

'Add approvers' scope the search first

Consider changing the order of setting the scope and the search.

For keyboard and non-visual users this setting is harder to discover and accessed out of order - assuming the scope is set first and the search second.

Form submission at end of form

Consider moving the form submission into the content of the drawer, giving a more logical order

Drawer keyboard trap

Drawer should have a keyboard trap, allowing users to get back to the x close button easily.

Target branch dropdown migration

It looks like the target branch dropdown has only been partially migrated. The bottom two actions seem to be using the old styles.