Marking a project 'pending deletion' in a group that is 'pending deletion' displays two warning banners

Problem

Marking a group as pending deletion currently does not change write access to any of the subgroups and projects that the group contains. We currently do not display a warning message to users of those subgroups and projects that deletion is pending. This means users can go to a subgroup or project and mark them as pending deletion again. When that happens, we display two banners for projects:

Screenshot_2024-08-13_at_14.14.24

Proposal

Only one banner should be displayed. Decide how to handle the display of banners in nested subgroups and projects of a group that is pending deletion.

Proposed Fix

Remove all flash notices from adjourned deletion as the yellow banner is now persistent in all cases.

Implementation guide

  1. Remove flash notice from ee/groups_controller.rb
  2. Remove flash notice from ee/projects_controller.rb
Edited by Zack Cuddy