Allow multiple approvals for same user
Why
In Allow users to select which group to approve as (!150033 - merged) we allowed a user to select which group to approve as.
Here are more improvements
Improvement 1
- If the user belongs to multiple approver groups, they should be able to refresh the page and approve again as a different group. Right now it is grayed out once they approve 1 time.
Improvement 2
- If the user belongs to multiple approver groups, they should be able to check multiple groups to approve as and submit all at once. Right now they can only do one at a time.
UX Proposal:
- Add a section to the table that allows users to check multiple approvals.
- Adjust the button text to show which roles they are approving for.
Design |
---|
![]() |
Technical Proposal
- Change the radio button in
ee/app/assets/javascripts/environments/components/multiple_approval_rules_table.vue
to be aGlSelect
, or showing the icon and text when that rule has been approved or rejected by the user - Ensure the form is disabled if the deployment has been rejected.
- ensure the table emits a list of selected rules
- When calling the approval mutation, we must call it for each rule selected. we must also include the comment in ONLY the first mutation
- Ensure the button is dynamically updated to list the first rule
& N others
if more are selected.
Edited by Andrew Fontaine