Groups - Add option to filter out deleted groups from GroupsFinder
What / Why
This was found while implementing: !148701 (merged)
When deleting groups they are scheduled for deletion in the DestroyService. While this is happening the Groups GraphQL API returns null line items for these groups. This throws errors in the frontend. This does not occur in the Projects views due to the ProjectsFinder filtering out Projects currently being deleted.
This feature does not appear to be in the GroupsFinder and ideally we could replicate this logic for groups as well.
Important: This bug is only showing up currently in Organizations behind a feature flag ui_for_organizations
Video of bug
Groups (Bug) | Projects (No Bug) |
---|---|
Groups_Bug | Project_-_No_Bug |
Proposal
- Add a DB migration to add
pending_delete
to theGroup
table. - Add filter similar to ProjectsFinder to GroupsFinder
- Add scope similar to ProjectModel to GroupModel
- Add attribute similar to ProjectDestroyService to GroupDestroyService
Edited by Abdul Wadood