Links to job created by "new issue" is invalid

Summary

The links are invalid, if you open a job and click on new issue

Steps to reproduce

  1. Open a (failed) job
  2. Click on New Issue
  3. Save the issue it contains e.g. [#11537](/MYGROUP/MYPROJECT/-/jobs/11537)
  4. Click on the link on this issue to the job

What is the current bug behavior?

  1. The generated link is then: https://MYHOST/MYGROUP/MYPROJECT/master/MYGROUP/MYPROJECT/-/jobs/11537
  2. Opening the links displays 404 The page could not be found or you don't have permission to view it.

What is the expected correct behavior?

  1. The generated link should be: https://MYHOST/MYGROUP/MYPROJECT/-/jobs/11537
  2. Opening the link should display the related job

Relevant logs and/or screenshots

None additional

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:         Ubuntu 16.04
Proxy:          no
Current User:   git
Using RVM:      no
Ruby Version:   2.3.5p376
Gem Version:    2.6.13
Bundler Version:1.13.7
Rake Version:   12.1.0
Redis Version:  3.2.5
Git Version:    2.13.6
Sidekiq Version:5.0.4
Go Version:     unknown


GitLab information
Version:        10.2.4-ee
Revision:       a93af19
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     postgresql
DB Version:     9.6.5
URL:            https://MYHOST
HTTP Clone URL: https://MYHOST/some-group/some-project.git
SSH Clone URL:  git@MYHOST:some-group/some-project.git
Elasticsearch:  yes
Geo:            no
Using LDAP:     no
Using Omniauth: yes
Omniauth Providers: XXXX


GitLab Shell
Version:        5.9.4
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab Shell ...

GitLab Shell version >= 5.9.4 ? ... OK (5.9.4)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
19/6 ... ok
19/7 ... ok
19/8 ... ok
19/9 ... ok
18/25 ... ok
18/26 ... ok
18/27 ... repository is empty
17/30 ... ok
17/32 ... ok
18/33 ... repository is empty
19/34 ... ok
17/35 ... repository is empty
13/36 ... ok
19/37 ... ok
19/38 ... ok
20/39 ... ok
19/40 ... ok
19/41 ... ok
13/42 ... ok
17/43 ... ok
17/44 ... ok
17/45 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK


Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Sidekiq ...


Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Reply by email is disabled in config/gitlab.yml
Checking LDAP ...


LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
19/6 ... yes
19/7 ... yes
19/8 ... yes
19/9 ... yes
18/25 ... yes
18/26 ... yes
18/27 ... yes
17/30 ... yes
17/32 ... yes
18/33 ... yes
19/34 ... yes
17/35 ... yes
13/36 ... yes
19/37 ... yes
19/38 ... yes
20/39 ... yes
19/40 ... yes
19/41 ... yes
13/42 ... yes
17/43 ... yes
17/44 ... yes
17/45 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.5 ? ... yes (2.3.5)
Git version >= 2.7.3 ? ... yes (2.13.6)
Git user has default SSH configuration? ... yes
Active users: ... 12
Elasticsearch version 5.1 - 5.5? ... no (5.6.5)
For more information see:
doc/integration/elasticsearch.md


Checking GitLab ... Finished

Possible fixes

it looks like, that it adds a invalid base https://MYHOST/MYGROUP/MYPROJECT/master instead only to add https://MYHOST

Perhaps it's in a way related to Broken link on the pipelines page, but I assume, it's not the same bug.

Edited by Michael Decker