Update maintainer trainee process

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Why

Maintainer reviews come after an initial review. So the maintainer trainee review should come after an initial review as well, because they need to train to be a maintainer.

Currently, trainees get the initial review. The process looks like this:

  1. MR author sees a maintainer trainee suggested as initial reviewer and adds them as initial reviewer.
  2. No one else has reviewed it so Trainee is now reviewing as an initial reviewer.
  3. Trainee sends to maintainer when done.

Trainee shouldn't just be doing these initial reviews. They need to do maintainer style reviews which come after at least 1 initial review.

I think having trainees do initial reviews makes the training process less efficient by decreasing the chance that they get any maintainer style reviews in.

Proposal

Let's change the process so trainees get real experience doing the Maintainer review, not an initial review. High level:

  1. MR author gets an appropriate initial reviewer to review their MR.
  2. Maintainer trainee reviews.
  3. Maintainer reviews.

How

Not sure yet, it might work to raise more awareness about who is currently in training and ask MR authors to forward MR reviews to a trainee after an initial review. Maybe we could also automate this somehow.

Another options is having mentors forward MRs they get pinged on to their mentees.

The extra review will slow down the process so it might be better to let this be manual/opt-in at the author's discretion.

Edited by 🤖 GitLab Bot 🤖