Review queries in container_repository_details_spec.rb
Review the test file spec/requests/api/graphql/container_repository/container_repository_details_spec.rb
as we have been receiving flaky test reports.
An MR has been opened to fix 2 of the examples and a similar fix might be needed for others that were also reported to be flaky. This issue aims to look more thoroughly in the queries in that test file and see if anything could be simplified.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Adie (she/her) changed milestone to %17.0
changed milestone to %17.0
- Adie (she/her) set weight to 2
set weight to 2
- Radamanthus Batnag mentioned in merge request !148370 (merged)
mentioned in merge request !148370 (merged)
- Radamanthus Batnag mentioned in issue #454038 (closed)
mentioned in issue #454038 (closed)
- Maintainer
After we have resolved this, we can remove the spec from fast quarantine:
1 mentioned in commit gitlab-org/quality/engineering-productivity/fast-quarantine@626cc657
- Radamanthus Batnag mentioned in merge request gitlab-org/quality/engineering-productivity/fast-quarantine!170 (merged)
mentioned in merge request gitlab-org/quality/engineering-productivity/fast-quarantine!170 (merged)
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#5722 (closed)
- Author Maintainer
Collapse replies - Author Maintainer
- Tim Rizzi added Package:P1 label
added Package:P1 label
- Tim Rizzi mentioned in issue #451600 (closed)
mentioned in issue #451600 (closed)
- Crystal Poole added workflowready for development label
added workflowready for development label
- Crystal Poole added Deliverable label
added Deliverable label
- Maintainer
Setting health status to
on track
as the milestone has just begun.Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to on track
changed health status to on track
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17270 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17270 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17346 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17346 (closed)
- Maintainer
This issue is scheduled for completion in this milestone but doesn't have an assignee. Changing health status to 'needs attention'.
Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to needs attention
changed health status to needs attention
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17445 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17445 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17612 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17612 (closed)
- Maintainer
This issue is scheduled for completion in this milestone but doesn't have an assignee. Changing health status to 'at risk'.
Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to at risk
changed health status to at risk
- Tim Rizzi mentioned in issue #458781 (closed)
mentioned in issue #458781 (closed)
- Maintainer
Setting health status to
on track
as the milestone has just begun.Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to on track
changed health status to on track
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17715 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17715 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17797 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17797 (closed)
- Adie (she/her) assigned to @adie.po
assigned to @adie.po
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17903 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17903 (closed)
- Author Maintainer
Async UpdatesMR: !153769 (merged)
I have opened a merge request to simplify the main query in this test file. It is now approved
and mergedThe next step is to remove the quarantine and verify if the tests are still flaky.
Edited by Adie (she/her) - Adie (she/her) added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Author Maintainer
Async UpdatesMR: gitlab-org/quality/engineering-productivity/fast-quarantine!194 (merged)
I have now removed the test from quarantine in the MR above. Merged it as well
Will monitor if any of the issues happen again.
- Author Maintainer
Async Updates-
MR to minimize query size: !153769 (merged) -
MR to remove from quarantine: gitlab-org/quality/engineering-productivity/fast-quarantine!194 (merged) -
MR to fix and improve tests: !154265 (merged)
All the above MRs are now merged. So far, no new flaky test errors have come up. Will monitor until next week and close this issue once no new flaky test errors from this file comes up.
-
- Tim Rizzi mentioned in issue #464609 (closed)
mentioned in issue #464609 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18068 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18068 (closed)
- Author Maintainer
Closing this issue now, no new timeout errors occurred
- Adie (she/her) closed
closed