Iterate on false positives in Rubocop enforcing factories for new tables
Summary
Rubocop added with Add Rubocop to enforce factories for new tables (!146536 - merged) has false-positive cases for some tables. Example 20240115185037_create_packages_terraform_module_metadata
=> packages_terraform_module_metadata
table doesn't correspond with terraform_module_metadatum
factory and Packages::TerraformModule::Metadatum
class.
Another example of false positive - https://gitlab.com/gitlab-org/gitlab/-/jobs/6546775383:
added the factory, but ofc my table is
p_ci_builds_execution_configs
- And rubocop failsMigration/EnsureFactoryForTable: No factory found for the table p_ci_builds_execution_configs
Factory name isci_builds_execution_configs
inspec/factories/ci/builds_execution_configs.rb
spotted another pattern.
ci_build_name
's factory goes intospec/factories/ci/build_name.rb