Follow-up from "Show Duo Pro button for ultimate trial"
The following discussions from !147548 (merged) should be addressed:
-
@dstull started a discussion: suggestion (non-blocking):
for follow-up.
We are breaking some of the effort here to not relay on magical
@group
being set in a partial here by using it instead ofnamespace
that is@group
, but passed in.We should be using
namespace
here- if show_code_suggestions_card?(namespace) = render 'paid_and_trial_plan_duo_pro_card' #js-billing-plans{ data: subscription_plan_data_attributes(namespace, current_plan, read_only: read_only) }
-
@dstull started a discussion: suggestion (non-blocking):
For follow-up:
It might be better isolation here to pass in the magical
@group
asnamespace
here when using it in a partial as it can become hard to follow/understand how they are set when used outside of the parent template.
Edited by Serhii Yarynovskyi