[FE] - [CS ForRegistry] - Implement Image/Tag column in vuln report table
Why are we doing this work
- add image/tag column to table
Relevant links
Non-functional requirements
-
Documentation: -
Testing:
Implementation plan
-
Add behind feature flag CS_FOR_REGISTRY -
If using @skipor@includedirective, then the resolver must exist in backend FIRST but featured flag out to returnundefinedornullif the flag is off. -
Otherwise client side feature flag uses two versions of a query conditionally. -
frontend show the image,severity, andstatusfilters -
frontend show the Image and tagcolumn
Implementation Details
-
Make changes as described in POC !145758 (fc6d9ed9) -
Add unit tests
backend backend Needs
-
Look at !145758 (fc6d9ed9) -
Need to add new image_and_tagkey or something similar for new table column -
NO-OPresolvers must exist for the fields we are requestingimage_and_tagbehind feature flag if I am to use the@include,@skipdirectives, otherwise a javascript exception will occur.
Weight Reasoning
3 - If need two queries
2 - If can use @skip, @include directives if we have a stubbed out resolver.
- Still need to handle feature flag logic. Depending if backend gets feature flagged resolvers implemented first, or if I will need to work around that by implementing 2 queries client side. 2 query versions increases complexity.
Verification steps
- Upload a GitLab Ultimate license
- Navigate to a project => Security & Compliance => Vulnerability Report => Container registry vulnerabilities tab
- Ingest a SBOM report with
metadata.toolsas registry event set as a part of [CS For Registry] Set SBOM occurrence source to... (#443634 - closed) - Verify that db records are created as per the requirements.
- Run advisory scanner and report parser.
- Verify that the vulnerabilities are created with report_type: CONTAINER_SCANNING_FOR_REGISTRY
- Verify that the group and project GraphQL endpoints returns these vulnerabilities on applying the filter for report_type: CONTAINER_SCANNING_FOR_REGISTRY.
Edited by Fernando Cardenas
