Skip to content

Update how member filters work

Background

In &11023 (closed) we are working on listing members of shared groups. Currently the filters don't work for shared members. If you apply a filter then no shared members are listed. There was discussion about this in #429341 (comment 1619448597)

Proposal

Related discussion - #429341 (comment 1785271203)

Update filters to work as described below:

  • No filters
    • All members show including members from shared groups
  • Direct filter
    • Members directly invited to a group/project
  • Indirect filter
    • Members inherited from a parent group
    • Members from from shared group

Implementation plan

Backend

Needs refinement. Looks like app/controllers/concerns/membership_actions.rb#L148-162 is responsible for filters

Frontend

Ping @peterhegman if you need frontend support

  1. Update options title property in app/assets/javascripts/members/constants.js#L142 to Direct and Indirect. value property should match what is used in the backend.
Edited by Peter Hegman