Follow-up from "Show deployment approval comments"
The following discussion from !144912 (merged) should be addressed:
-
@andrei.zubov started a discussion: (+1 comment)
[thought] I've also noticed that the page is not very mobile friendly:
header header Let's create an issue to improve it?
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Andrew Fontaine assigned to @afontaine
assigned to @afontaine
- Maintainer
@afontaine, Please add a group or category label to identify issue ownership.You can refer to the Features by Group handbook page for guidance.
If you are unsure about the correct group, please do not leave the issue without a group label, and refer to GitLab's shared responsibility functionality guidelines for more information on how to triage this kind of issue.
This message was generated automatically. You're welcome to improve it.
- Contributor
This issue was automatically tagged with the label ~"group::configure" by TanukiStan, a machine learning classification model, with a probability of 0.38.
If this label is incorrect, please tag this issue with the correct group label as well as automation:ml wrong to help TanukiStan learn from its mistakes.
If you are unsure about the correct group, please do not leave the issue without a group label. Please refer to GitLab's shared responsibility functionality guidelines for more information on how to triage this kind of issues.
Authors who do not have permission to update labels can use the
@gitlab-bot label ~"group::<correct group name>"
command, or leave the issue to be triaged by group leaders initially assigned by TanukiStan.This message was generated automatically. You're welcome to improve it.
- A deleted user added automation:ml label
added automation:ml label
- Andrew Fontaine added groupenvironments label
added groupenvironments label
- 🤖 GitLab Bot 🤖 added devopsdeploy sectioncd labels
added devopsdeploy sectioncd labels
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16623 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16623 (closed)
- Andrew Fontaine mentioned in merge request !146411 (merged)
mentioned in merge request !146411 (merged)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16726 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16726 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16806 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16806 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16912 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16912 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16992 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16992 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17186 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17186 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17265 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17265 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17341 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17341 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17440 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17440 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17607 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17607 (closed)
- Andrew Fontaine added workflowrefinement label
added workflowrefinement label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17709 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17709 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17794 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17794 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17900 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17900 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18065 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18065 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18164 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18164 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18246 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18246 (closed)
- Author Maintainer
I think this might need a look as to how to make the whole page mobile friendly, including the sidebar @emilybauman
Doesn't seem like an easy fix :(
Edited by Andrew Fontaine Collapse replies - Developer
@afontaine - Given this page was modaled after the MR Page, we could potentially just use some of the patterns they have (the sidebar stays collapsed and can be expanded over everything) and the approver table stacks similar to our table component.
We'd just need to wrap everything else as normal then.
cc: @nagyv-gitlab
- Developer
Is this a duplicate of Deployment details page is not mobile friendly (#458785 - closed) ?
I'm marking it as such. Let me know if I'm wrong.
Edited by Viktor Nagy (GitLab)
- Andrew Fontaine unassigned @afontaine
unassigned @afontaine
- Anna Vovchenko added frontend label
added frontend label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18353 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18353 (closed)
- Viktor Nagy (GitLab) marked this issue as a duplicate of #458785 (closed)
marked this issue as a duplicate of #458785 (closed)
- Viktor Nagy (GitLab) closed
closed
- Viktor Nagy (GitLab) marked this issue as related to #458785 (closed)
marked this issue as related to #458785 (closed)