Skip to content

Users with Minimal Access and Reporter roles can't add contacts to issues

Summary

  • The docs mention users need the reporter role to add contacts to an issue [doc link]
  • Users with the reporter role should observe the /add_contacts quick action in the issue/comment composer [doc link]
  • It appears that a user with the minimal access role at the namespace-level and reporter role at a lower level will not observe the /add_contacts quick action

Example tickets:

  1. ZD#505158

Steps to reproduce

  • Create new namespace and enable the CRM feature
  • Add a user to a namespace with the minimal access role
  • Create a project inside the namespace and add the user with the reporter role assigned
  • As the user, create an issue an attempt to use the /add_contacts quick action. In my testing it did not appear in:
    • The new issue composer
    • The existing issue edit composer
    • The comment composer on the issue

Example Project

  • At first I tested whether having zero contacts configured would suppress the quick action - it does, but adding a contact makes it work.
  • I then tested this with my ultimate-tier sandbox (rrelax_ultimate_group) so I could utilise the ultimate-tier only minimal access role
    • An issue was created here: rrelax_ultimate_group/review-party-component/-/issues/1
    • My personal account @mcatee was given minimal access at the top level and reporter in rrelax_ultimate_group/review-party-component, and the macro was not available (whereas it was when @mcatee was given the reporter role at the namespace level)

What is the current bug behavior?

A user who (by the docs) should be eligible to add contacts to an issue is not able to

What is the expected correct behavior?

A user with the minimal access role at the top level and reporter role at a lower level should be able to use the add_contacts quick action

Relevant logs and/or screenshots

image

Output of checks

Results of GitLab environment info

N/A

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

N/A

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes