Dead link on Admin Area
Summary
There is a link to "Upgrade GitLab" documentation on the Admin Area.
However, this is linked to the documentation archive. Therefore, when the version of the instance is not available in the documentation archive, this link becomes dead link.
This can happen not only with very old versions. This happens in relatively recent but need to be updated versions. (For example, 16.5.3)
Steps to reproduce
- Install GitLab that version needs to be upgraded
- Go to Admin Area
- Click "Update ASAP"
Example Project
N/A
What is the current bug behavior?
screenshot 2024-02-08 14.51.17.mov
The "Update ASAP" is linked to https://docs.gitlab.com/16.5/ee/update/index.html
However, this is dead link because 16.5 is not exist in documentation archive.
What is the expected correct behavior?
screenshot 2024-02-08 14.35.59.mov
The "Update ASAP" is linked to https://docs.gitlab.com/16.7/ee/update/index.html
Relevant logs and/or screenshots
Please see above sections.
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Proxy: no Current User: git Using RVM: no Ruby Version: 3.0.6p216 Gem Version: 3.4.19 Bundler Version:2.4.20 Rake Version: 13.0.6 Redis Version: 7.0.13 Sidekiq Version:6.5.7 Go Version: unknown GitLab information Version: 16.5.3-ee Revision: 8583797ef98 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 14.9 URL: https://gitlab-docker.kosk1011.tokyo HTTP Clone URL: https://gitlab-docker.kosk1011.tokyo/some-group/some-project.git SSH Clone URL: ssh://git@gitlab-docker.kosk1011.tokyo:2222/some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 14.29.0 Repository storages: \- default: unix:/var/opt/gitlab/gitaly/gitaly.socket GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Gitaly \- default Address: unix:/var/opt/gitlab/gitaly/gitaly.socket \- default Version: 16.5.3 \- default Git Version: 2.42.0
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ... Checking GitLab Shell ... GitLab Shell: ... GitLab Shell version \>= 14.29.0 ? ... OK (14.29.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful Checking GitLab Shell ... Finished Checking Gitaly ... Gitaly: ... default ... OK Checking Gitaly ... Finished Checking Sidekiq ... Sidekiq: ... Running? ... yes Number of Sidekiq processes (cluster/worker) ... 1/1 Checking Sidekiq ... Finished Checking Incoming Email ... Incoming Email: ... Reply by email is disabled in config/gitlab.yml Checking Incoming Email ... Finished Checking LDAP ... LDAP: ... LDAP is disabled in config/gitlab.yml Checking LDAP ... Finished Checking GitLab App ... Database config exists? ... yes Tables are truncated? ... skipped All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Cable config exists? ... yes Resque config exists? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet) Systemd unit files or init script exist? ... skipped (omnibus-gitlab has neither init script nor systemd units) Systemd unit files or init script up-to-date? ... skipped (omnibus-gitlab has neither init script nor systemd units) Projects have namespace: ... can't check, you have no projects Redis version \>= 6.0.0? ... yes Ruby version \>= 3.0.6 ? ... yes (3.0.6) Git user has default SSH configuration? ... yes Active users: ... 1 Is authorized keys file accessible? ... yes GitLab configured to store new projects in hashed storage? ... yes All projects are in hashed storage? ... yes Elasticsearch version 7.x-8.x or OpenSearch version 1.x ... skipped (Advanced Search is disabled) All migrations must be finished before doing a major upgrade ... skipped (Advanced Search is disabled) Checking GitLab App ... Finished Checking GitLab subtasks ... Finished
Possible fixes
Under normal circumstances, the documentation for the latest version is required for upgrades because there are upgrade paths from the version the customer is currently using to the latest version.
Therefore, I suggest that the link from this button be changed from the archive of the specific version to the documentation of the latest version (https://docs.gitlab.com/ee/update/index.html).