Remove support for Aggregated Metric of the type "intersect"
Problem
Aggregated metrics with the operator AND
is not used in any metrics.
As you can see in !138669 (merged) it cost us time to maintain and review changes to the codebase.
Desired Outcome
The functionality is removed from the code base and the docs
Potential Solution(s)
The plan is to remove the feature entirely in a few steps to make reviews easier:
- Remove usage of the
Intersection
class from all sourcespostgres_hll
andredis_hll
. ( - Remove the
Intersection
class and support for using theAND
operator - Remove all usage of the
operator
property in the code - Update generator to output metric definitions without
operator
. (Requires thatoperator
becomes optional in the json schema - Migrate remove
operator
from all (currently 77) aggregated metric definitions - Update json schema do disallow the
operator
property
For item 4-6 we have to verify with the Data teams DBT models that the operator is not being used.
How to verify
- Make sure that
aggregated
metrics are still computed correctly on production
Further actions needed
Edited by Jonas Larsen