Air-gapped instances can't update settings due to outside checks
Summary
Self-managed air-gapped instance can't update some settings, bot update_runner_versions_enabled
and diagramsnet_enabled
are blocking each other and other settings from being updated due to outside world checks.
Saving settings for air-gapped instances results in a error.
Steps to reproduce
- Run GitLab air-gapped instance ( tested on 16.7 and 16.8)
- Try to disable Diagrams.net or "Fetch GitLab Runner release version data from GitLab.com" options
Example Project
N/A
What is the current bug behavior?
Can't save settings due to unreachable URL's
What is the expected correct behavior?
Settings are saved regardless of reachability
Relevant logs and/or screenshots
N/A
Output of checks
N/A
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`) System information System: Ubuntu 20.04 Proxy: no Current User: git Using RVM: no Ruby Version: 3.1.4p223 Gem Version: 3.4.22 Bundler Version:2.5.4 Rake Version: 13.0.6 Redis Version: 7.0.15 Sidekiq Version:7.1.6 Go Version: unknown GitLab information Version: 16.8.1-ee Revision: 1242b447720 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 13.12 URL: some-url HTTP Clone URL: some-url SSH Clone URL: some-url Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 14.33.0 Repository storages: - default: unix:/var/opt/gitlab/gitaly/gitaly.socket GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Gitaly - default Address: unix:/var/opt/gitlab/gitaly/gitaly.socket - default Version: 16.8.1 - default Git Version: 2.42.0 -
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
Implement #384170 or specific fix for this