Remove id from code action ci configuration yaml

Issue

The following discussion from !143095 (merged) should be addressed:

  • @arfedoro started a discussion: (+5 comments)

    @mcavoj could you please take over initial review?

  • @mcavoj

    I noticed we have id under ci_configuration.include, and I could bypass file validations and could get to a pretty weird state by changing that value. I assume this id is not actually used anywhere in the backend processing and the project, ref and file is what matters (as described in the docs), but I'm wondering if we should address that and not put it in the YAML. I didn't follow the discussions around that, so I'm not sure if it was already discussed in the epic.

  • @arfedoro

    You are right only project, ref and file are essential for backend

    But there is no better way to way to select project from listbox for existing polices, rather then using id, so I preserve it as well only for that purpose

Proposal

actions:
  - scan: custom
    ci_configuration: |
      include:
        project: gitlab-org/gitlab-test
        id: 2

to

actions:
  - scan: custom
    ci_configuration: |
      include:
        project: gitlab-org/gitlab-test

Implementation

Edited by Alexander Turinske