License Compliance (License List) UI Removal
This issue covers the effort needed to remove the Vue code from
https://gitlab.com/gitlab-org/gitlab/-/licenses
Things to remove:
-
Rails route to the project licenses
-/licenses -
Removal of licenses controller at
ee/app/controllers/projects/licenses_controller.rb -
Removal of Rails haml views for license page at
ee/app/views/projects/licenses/index.html.haml -
Removal of Sidebar Menu entry at
ee/lib/ee/sidebars/projects/menus/security_compliance_menu.rb -
Removal of any related specs and E2E tests
-
Refactor of Vue code at
ee/app/assets/javascripts/license_compliance. Needs a deeper dive and workflowrefinement. At some point we used VueX modules to share implementations across multiple pages. It is still shared between the license list page and the Pipeline View -> Licenses tab .
Example of other possible usage we don't want to remove: https://gitlab.com/gitlab-org/frontend/playground/gitlab-mr-widgets-demo/-/pipelines/1102329953/licenses
Proposal (Achieve removal in two phases)
Phase 1 (user facing)
To satisfy the %17.0 removal we should do the quick and easy
- Rails route to the project licenses
-/licenses - Removal of licenses controller at
ee/app/controllers/projects/licenses_controller.rb - Removal of Rails haml views for license page at
ee/app/views/projects/licenses/index.html.haml - Removal of Sidebar Menu entry at
ee/lib/ee/sidebars/projects/menus/security_compliance_menu.rb - Removal of any related specs and E2E tests
- Leave existing Vue app code in place since it's used in the Pipeline -> Licenses tab.
Phase 2 (can be done anytime after %17.0 non-user facing)
- Refactor of Vue code at
ee/app/assets/javascripts/license_compliance. This would be non-user facing tech debt and more involved. Involves removing from shared directories, removing unused VueX modules.