Audit semver_dialects tests
Why are we doing this work
As we increase our reliance on the semver_dialects gem and did several recent changes in the project, we've discovered that several specs where not written appropriately making the tests actually useless.
- expect(range.size == 3)
+ expect(range.size).to eq(3)
To ensure we have a proper coverage we should audit the tests of this project and correct them when the syntax is incorrect.
Relevant links
- https://gitlab.com/gitlab-org/vulnerability-research/foss/semver_dialects/-/merge_requests/10+s
- https://gitlab.com/gitlab-org/vulnerability-research/foss/semver_dialects/-/merge_requests/12+s
- https://gitlab.com/gitlab-org/vulnerability-research/foss/semver_dialects/-/merge_requests/23+s
- https://gitlab.com/gitlab-org/vulnerability-research/foss/semver_dialects/-/merge_requests/24+s
Implementation plan
-
Review all tests files in the semver_dialects project and ensure the rspec syntax is correct and the tests are effective.
Edited by Philip Cunningham