Failure in spec/lib/service_ping/build_payload_spec.rb
This test spec/lib/service_ping/build_payload_spec.rb
can only pass with rspec-retry
and it'll not pass locally, failing with: https://gitlab.com/gitlab-org/gitlab/-/jobs/5939340385
Failures:
1) ServicePing::BuildPayload#execute behaves like complete service ping payload behaves like service ping payload with all expected metrics
Failure/Error: yield
NoMethodError:
undefined method `license_id' for nil:NilClass
::License.current.send(license_attribute) # rubocop: disable GitlabSecurity/PublicSend
^^^^^
Shared Example Group: "service ping payload with all expected metrics" called from ./spec/support/shared_examples/services/service_ping/complete_service_ping_payload_shared_examples.rb:4
Shared Example Group: "complete service ping payload" called from ./spec/lib/service_ping/build_payload_spec.rb:11
# ./ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb:41:in `block in value'
# ./lib/gitlab/utils/usage_data.rb:200:in `block in alt_usage_data'
# ./lib/gitlab/utils/usage_data.rb:48:in `with_metadata'
# ./lib/gitlab/utils/usage_data.rb:198:in `alt_usage_data'
# ./ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb:39:in `value'
It's quarantined in !141874 (merged)
The following discussion from !141874 (merged) should be addressed:
-
@godfat-gitlab started a discussion: (+6 comments) Looks like we have the first test which cannot pass without
rspec-retry
! https://gitlab.com/gitlab-org/gitlab/-/jobs/5939340385I'll try to fix them.