Fix Workhorse linter warnings (part 15)
Problem
make golangci
linter detects warnings in following Workhorse files
How to verify
make golangci | grep -E "^internal/httprs"
internal/httprs/httprs.go:113:8: Error return value of `r.Seek` is not checked (errcheck)
internal/httprs/httprs.go:151:7: shadow: declaration of "err" shadows declaration at line 137 (govet)
internal/httprs/httprs.go:198:20: response body must be closed (bodyclose)
internal/httprs/httprs.go:33:6: var-naming: type HttpReadSeeker should be HTTPReadSeeker (revive)
internal/httprs/httprs.go:64:6: var-naming: func NewHttpReadSeeker should be NewHTTPReadSeeker (revive)
internal/httprs/httprs_test.go:121:24: response body must be closed (bodyclose)
internal/httprs/httprs_test.go:13:2: dot-imports: should not use dot imports (revive)
internal/httprs/httprs_test.go:166:6: var-naming: func testHttpReaderSeeker should be testHTTPReaderSeeker (revive)
internal/httprs/httprs_test.go:167: unnecessary leading newline (whitespace)
internal/httprs/httprs_test.go:30:36: unused-parameter: parameter 'b' seems to be unused, consider removing or renaming it as _ (revive)
internal/httprs/httprs_test.go:85:6: shadow: declaration of "err" shadows declaration at line 81 (govet)
Solution
Resolve warnings
Edited by Vasilii Iakliushin