Fix Workhorse linter warnings (part 10)
Problem
make golangci
linter detects warnings in following Workhorse files
How to verify
make golangci | grep -E "^internal/dependencyproxy/"
internal/dependencyproxy/dependencyproxy.go:128:20: var-naming: method fetchUrl should be fetchURL (revive)
internal/dependencyproxy/dependencyproxy.go:140:2: var-naming: var uploadUrl should be uploadURL (revive)
internal/dependencyproxy/dependencyproxy.go:177:6: var-naming: var uploadUrl should be uploadURL (revive)
internal/dependencyproxy/dependencyproxy.go:194:20: var-naming: method uploadUrlFrom should be uploadURLFrom (revive)
internal/dependencyproxy/dependencyproxy.go:1:1: package-comments: should have a package comment (revive)
internal/dependencyproxy/dependencyproxy.go:27:6: exported: exported type Injector should have comment or be unexported (revive)
internal/dependencyproxy/dependencyproxy.go:33:2: var-naming: struct field Url should be URL (revive)
internal/dependencyproxy/dependencyproxy.go:41:2: var-naming: struct field Url should be URL (revive)
internal/dependencyproxy/dependencyproxy.go:63:1: exported: exported function NewInjector should have comment or be unexported (revive)
internal/dependencyproxy/dependencyproxy.go:67:1: exported: exported method Injector.SetUploadHandler should have comment or be unexported (revive)
internal/dependencyproxy/dependencyproxy.go:71:1: exported: exported method Injector.Inject should have comment or be unexported (revive)
internal/dependencyproxy/dependencyproxy.go:89:37: Error return value of `dependencyResponse.Body.Close` is not checked (errcheck)
internal/dependencyproxy/dependencyproxy.go:92:10: Error return value of `io.Copy` is not checked (errcheck)
internal/dependencyproxy/dependencyproxy_test.go:108:115: string `/url"}` has 3 occurrences, make it a constant (goconst)
internal/dependencyproxy/dependencyproxy_test.go:181:16: `overriden` is a misspelling of `overridden` (misspell)
internal/dependencyproxy/dependencyproxy_test.go:190:16: `overriden` is a misspelling of `overridden` (misspell)
internal/dependencyproxy/dependencyproxy_test.go:199:16: `overriden` is a misspelling of `overridden` (misspell)
internal/dependencyproxy/dependencyproxy_test.go:240:4: var-naming: var sendDataJsonString should be sendDataJSONString (revive)
internal/dependencyproxy/dependencyproxy_test.go:245:4: commentFormatting: put a space between `//` and comment text (gocritic)
internal/dependencyproxy/dependencyproxy_test.go:264:27: `overriden` is a misspelling of `overridden` (misspell)
internal/dependencyproxy/dependencyproxy_test.go:291:4: var-naming: var sendDataJsonString should be sendDataJSONString (revive)
internal/dependencyproxy/dependencyproxy_test.go:310:6: var-naming: var oldHttpClient should be oldHTTPClient (revive)
internal/dependencyproxy/dependencyproxy_test.go:323:2: var-naming: var sendDataJsonString should be sendDataJSONString (revive)
internal/dependencyproxy/dependencyproxy_test.go:327:61: response body must be closed (bodyclose)
internal/dependencyproxy/dependencyproxy_test.go:40:33: unused-parameter: parameter 'h' seems to be unused, consider removing or renaming it as _ (revive)
Solution
Resolve warnings
Edited by Vasilii Iakliushin